Make Partition family of APIs use reduce_then_scan algorithm #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
1985c58
to
973e261
Compare
danhoeflinger
force-pushed
the
dev/shared/partition_reduce_then_scan
branch
from
013c496
to
dadb933
Compare
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
973e261
to
91120af
Compare
danhoeflinger
force-pushed
the
dev/shared/partition_reduce_then_scan
branch
from
dadb933
to
eafdcc0
Compare
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
91120af
to
b517414
Compare
danhoeflinger
force-pushed
the
dev/shared/partition_reduce_then_scan
branch
from
eafdcc0
to
c7c043e
Compare
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
b517414
to
d85ce61
Compare
danhoeflinger
force-pushed
the
dev/shared/partition_reduce_then_scan
branch
from
c7c043e
to
d2f9639
Compare
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
d85ce61
to
df6abff
Compare
danhoeflinger
force-pushed
the
dev/shared/partition_reduce_then_scan
branch
from
d2f9639
to
6cbb5dd
Compare
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
df6abff
to
e33efaa
Compare
danhoeflinger
force-pushed
the
dev/shared/partition_reduce_then_scan
branch
from
6cbb5dd
to
06da0e2
Compare
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
e33efaa
to
5f4882a
Compare
danhoeflinger
force-pushed
the
dev/shared/partition_reduce_then_scan
branch
from
06da0e2
to
edf26c5
Compare
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
5f4882a
to
522d0af
Compare
danhoeflinger
force-pushed
the
dev/shared/partition_reduce_then_scan
branch
from
edf26c5
to
1ae6489
Compare
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
522d0af
to
6696396
Compare
danhoeflinger
force-pushed
the
dev/shared/partition_reduce_then_scan
branch
from
1ae6489
to
aae11db
Compare
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
6696396
to
f757df5
Compare
danhoeflinger
force-pushed
the
dev/shared/partition_reduce_then_scan
branch
from
aae11db
to
207bfed
Compare
danhoeflinger
changed the title
This was referenced Aug 6, 2024
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
f757df5
to
3301a89
Compare
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
81d9e2b
to
e35fe10
Compare
danhoeflinger
force-pushed
the
dev/shared/partition_reduce_then_scan
branch
from
8f2cd6a
to
44bab2f
Compare
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
e35fe10
to
d318354
Compare
danhoeflinger
force-pushed
the
dev/shared/partition_reduce_then_scan
branch
from
44bab2f
to
a93f24f
Compare
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
d318354
to
1da7875
Compare
danhoeflinger
force-pushed
the
dev/shared/partition_reduce_then_scan
branch
from
a93f24f
to
cf5a6be
Compare
julianmi
approved these changes
Aug 29, 2024
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
1da7875
to
8601892
Compare
danhoeflinger
force-pushed
the
dev/shared/partition_reduce_then_scan
branch
from
cf5a6be
to
c8298cb
Compare
danhoeflinger
commented
Aug 29, 2024
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
8601892
to
df02a01
Compare
danhoeflinger
force-pushed
the
dev/shared/partition_reduce_then_scan
branch
from
c8298cb
to
040a1ef
Compare
danhoeflinger
force-pushed
the
dev/shared/copy_if_reduce_then_scan
branch
from
df02a01
to
75c55c4
Compare
This reverts commit 3d69c3c.
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
danhoeflinger
force-pushed
the
dev/shared/partition_reduce_then_scan
branch
from
040a1ef
to
bd6aba6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes partition family of scan-like algorithms to use reduce_then_scan where it is beneficial.
Moves all algorithm selection decisions to __parallel_partition_copy.
This PR is targeted to #1763, to allow for a clean diff, and is a part of the following sequence of PRs meant to be merged in order:
#1769 [MERGED]
Relocate __lazy_ctor_storage to utils header#1770 [MERGED]
Use __result_and_scratch_storage within scan kernels#1762 Add reduce_then_scan algorithm for transform scan family
#1763 Make Copy_if family of APIs use reduce_then_scan algorithm
#1764 Make Partition family of APIs use reduce_then_scan algorithm (This PR)
#1765 Make Unique family of APIs use reduce_then_scan algorithm
This work is a collaboration between @mmichel11 @adamfidel and @danhoeflinger, and based upon an original prototype by Ted Painter.